Skip to content

Fix web frame previews in right sidebar - #95

Merged
pcarrier merged 4 commits into
mainfrom
fix/web-frame-sidebar-previews
Jul 29, 2026
Merged

Fix web frame previews in right sidebar#95
pcarrier merged 4 commits into
mainfrom
fix/web-frame-sidebar-previews

Conversation

@pcarrier

@pcarrier pcarrier commented Jul 29, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Summary

  • render backgrounded web frames in the right sidebar
  • keep each web frame mounted in one workspace-owned persistent layer
  • move lightweight visual hosts between non-BSP, BSP, and dock locations so backgrounding/restoring does not reload the iframe
  • preserve status-bar navigation handles and make dock previews inert
  • add regression coverage for focused/foreground/dock host selection

Validation

  • pnpm run typecheck
  • pnpm run test (38 tests)
  • pnpm run build
  • Prettier check

@github-actions

github-actions Bot commented Jul 29, 2026 •
edited
Loading

Copy link
Copy Markdown

Coverage

Crate Lines Functions Regions
alacritty-driver 69.7% (698/1002) 72.0% (54/75) 71.7% (1050/1464)
browser 0.0% (0/807) 0.0% (0/65) 0.0% (0/1370)
cli 18.2% (1520/8342) 28.5% (200/701) 21.0% (2729/12984)
compositor 1.0% (93/9248) 2.0% (8/400) 1.2% (146/12403)
fonts 81.4% (721/886) 88.6% (70/79) 83.0% (1427/1719)
fssync 90.1% (3496/3878) 90.9% (288/317) 90.2% (6218/6894)
gateway 26.1% (375/1437) 29.9% (38/127) 19.9% (470/2362)
git 85.3% (2889/3385) 88.8% (231/260) 85.2% (4584/5379)
lsp 76.0% (2503/3295) 78.2% (248/317) 73.8% (3886/5266)
proxy 19.3% (172/892) 20.5% (26/127) 21.2% (293/1381)
remote 89.1% (7723/8665) 92.1% (574/623) 87.3% (12907/14791)
sd-notify 69.6% (64/92) 100.0% (6/6) 80.9% (106/131)
server 35.8% (5965/16646) 49.8% (585/1174) 38.6% (10280/26604)
ssh 1.9% (7/374) 3.2% (1/31) 0.7% (4/613)
upsidedown 31.4% (391/1247) 27.8% (55/198) 34.8% (797/2287)
webrtc-forwarder 2.7% (72/2624) 2.1% (4/187) 1.2% (50/4335)
webserver 59.1% (995/1684) 64.3% (153/238) 62.4% (1737/2782)
Total 42.9% (27684/64504) 51.6% (2541/4925) 45.4% (46684/102765)

indent[bot]
indent Bot reviewed Jul 29, 2026
View reviewed changes
Comment thread js/ui/src/Workspace.tsx
indent[bot]
indent Bot reviewed Jul 29, 2026
View reviewed changes
Comment thread js/ui/src/PersistentWebPanes.tsx
@indent

indent Bot commented Jul 29, 2026 •
edited by indent-neo-staging Bot
Loading

Copy link
Copy Markdown
PR Summary

Generating summary...

Issues

Review closed.

CI Checks

1 CI check failed on 8393abc.

Failing lint
  • lint finished with failure.

@pcarrier
pcarrier merged commit 7311650 into main Jul 29, 2026
11 checks passed
@pcarrier
pcarrier deleted the fix/web-frame-sidebar-previews branch July 29, 2026 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@indent indent[bot] indent[bot] left review comments
@jsegaran jsegaran jsegaran approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@pcarrier @jsegaran